code-review

原文涵盖的主题

• Code Review
• 1. Establish scope
• 2. Understand intent before judging
• 3. Check, in priority order
• 4. Verify, don't guess
• 5. Output format

Goal: find the issues that actually matter, ranked by impact, with concrete fixes. Not a style lecture. Figure out what to review, in this order: 1. Files/snippets the user pointed at. 2. Otherwise git diff --staged; if empty, git diff; if empty, git diff main...HEAD (try master if main doesn't exist). 3. If still nothing, ask. Run scripts/collectdiff.sh to get the diff plus a file list in one go. Read the surrounding code of every changed hunk — bugs usually live at the boundary between new and old code, so the diff alone is not enough. Read the commit message / PR description / user's explanation. Ask yourself: what is this change trying to do? A review that misses the intent produces noise. 🔴 Blocker — correctness & security Logic errors, off-by-one, wrong conditions, unhandled null/undefined/None Async mistakes: missing await, unhandled promise rejections, async in forEach, race conditions, Python asyncio calls blocking the loop Injection: SQL string concatenation, eval/exec, shell commands built from input, dangerouslySetInnerHTML, Python pickle/yaml.load on untrusted data Secrets hard-coded, auth/permission checks missing on new endpoints Resource leaks: files/connections no

这里只展示节选，请以完整原文和当前要求为准。