code-review

原文涵盖的主题

• Sentry Code Review
• Review Checklist
• Identifying Problems
• Design Assessment
• Test Coverage
• Long-Term Impact
• Feedback Guidelines
• Tone

Follow these guidelines when reviewing code for Sentry projects. Look for these issues in code changes: Runtime errors: Potential exceptions, null pointer issues, out-of-bounds access Performance: Unbounded O(n²) operations, N+1 queries, unnecessary allocations Side effects: Unintended behavioral changes affecting other components Backwards compatibility: Breaking API changes without migration path ORM queries: Complex Django ORM with unexpected query performance Security vulnerabilities: Injection, XSS, access control gaps, secrets exposure Do component interactions make logical sense? Does the change align with existing project architecture? Are there conflicts with current requirements or goals? Every PR should have appropriate test coverage: Functional tests for business logic Integration tests for component interactions End-to-end tests for critical user paths Verify tests cover actual requirements and edge cases. Avoid excessive branching or looping in test code. Flag for senior engineer review when changes involve: Database schema modifications API contract changes New framework or library adoption Performance-critical code paths Security-sensitive functionality Be polite an

这里只展示节选，请以完整原文和当前要求为准。